Repository navigation
Conversation
yasithdev
force-pushed
the
interactive
branch
4 times, most recently
from
November 6, 2026 07:40
fe4802f to
f67e54f
Compare
yasithdev
force-pushed
the
interactive
branch
2 times, most recently
from
November 6, 2026 20:25
016fc9d to
4b1f32e
Compare
yasithdev
force-pushed
the
interactive
branch
2 times, most recently
from
November 7, 2026 07:43
6a92b3d to
97f47ec
Compare
This was referenced Nov 7, 2026
Contributor
|
@yasithdev can you fix merge conflicts? |
DImuthuUpe
requested changes
Nov 7, 2026
DImuthuUpe
left a comment
Contributor
There was a problem hiding this comment.
@yasithdev I can see some very important framework level fixes and interactive connection integration bundled in this PR. Can you try to make this 2 - 3 smaller PR with framework level fixes first and then linkspan integration later?
| case <-s.authWaitSignal: | ||
| case <-ctx.Done(): | ||
| return nil, ctx.Err() | ||
| return nil, context.Cause(ctx) |
| // banner and connection are set before the auth is published and never change, so | ||
| // they need no lock. connection is the client connection the prompts go back to. | ||
| banner string | ||
| connection string |
Contributor
There was a problem hiding this comment.
Why do we need another connection string?
| OwnerID string `gorm:"column:user_id;type:varchar(255);not null;index" json:"userId"` | ||
| CreatedAt int64 `gorm:"column:created_at;type:bigint;not null" json:"createdAt"` | ||
| CurrentProcessID string `gorm:"column:current_process_id;type:varchar(36);not null" json:"currentProcessId"` | ||
| } |
Contributor
There was a problem hiding this comment.
Can we use the same process object instead of session?
yasithdev
force-pushed
the
interactive
branch
2 times, most recently
from
November 8, 2026 23:48
0fcd99b to
ff6504a
Compare
yasithdev
marked this pull request as draft
November 8, 2026 23:48
Contributor
Author
|
Hi @DImuthuUpe, I raised #751-#755 by breaking down this PR as you suggested. |
yasithdev
force-pushed
the
interactive
branch
5 times, most recently
from
November 9, 2026 22:11
85c6562 to
682040b
Compare
yasithdev
force-pushed
the
interactive
branch
2 times, most recently
from
November 10, 2026 16:19
1305b17 to
3849f91
Compare
yasithdev
force-pushed
the
interactive
branch
from
November 10, 2026 18:16
3849f91 to
197c0e0
Compare
yasithdev
force-pushed
the
interactive
branch
5 times, most recently
from
November 11, 2026 21:13
924d02c to
bdd2c6d
Compare
yasithdev
force-pushed
the
interactive
branch
6 times, most recently
from
November 15, 2026 03:18
b90d210 to
1a654f6
Compare
yasithdev
force-pushed
the
interactive
branch
from
November 16, 2026 18:43
fad5990 to
125dd4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/processes/{id}/linkspan/…proxies Linkspan's API over the link./processes/{id}/jupyter/….baseUrlis now…/linkspan/api/v1/forward/{port}/.forward/{port}/…to that port over the link.SUBMITTEDbecomesRUNNINGwhen Linkspan dials.